Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement async method decode_audio_data (however still blocking IO) #500

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Implement async method decode_audio_data (however still blocking IO) #500

wants to merge 3 commits into from

Conversation

orottier
Copy link
Owner

Fixes #423

@orottier
Copy link
Owner Author

Build fails because we need to bump the MSRV to Rust 1.75 - https://blog.rust-lang.org/2023/12/21/async-fn-rpit-in-traits.html
1.75 was released end of december 2023
I don't think this PR is very important, so maybe let's wait till June so we can keep our MSRV to lag 6 months behind

@b-ma
Copy link
Collaborator

b-ma commented Apr 29, 2024

I don't think this PR is very important, so maybe let's wait till June so we can keep our MSRV to lag 6 months behind

Absolutely no problem on my side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add async method for BaseAudioContext::decodeAudioData
2 participants
@orottier @b-ma