Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compliant AudioBufferSourceNode and AudioBuffer #67

Merged
merged 38 commits into from
Dec 22, 2021
Merged

compliant AudioBufferSourceNode and AudioBuffer #67

merged 38 commits into from
Dec 22, 2021

Commits on Dec 11, 2021

  1. spec compliant AudioBuffer

    @b-ma
    b-ma committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    b3d35f5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature/audio-buffer-source-node

    @b-ma
    b-ma committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    a75c43b View commit details
    Browse the repository at this point in the history

  3. decodeAudioData first working draft

    @b-ma
    b-ma committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    8c7bb90 View commit details
    Browse the repository at this point in the history

  4. clean

    @b-ma
    b-ma committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    95412f6 View commit details
    Browse the repository at this point in the history

  5. cleaner architecture

    @b-ma
    b-ma committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    d36004d View commit details
    Browse the repository at this point in the history

  6. renamed param tests for what they actually do

    @b-ma
    b-ma committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    8aed8da View commit details
    Browse the repository at this point in the history

  7. comments

    @b-ma
    b-ma committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    680f01c View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2021

  1. added fade-out to remove artifact at the end the file

    @b-ma
    b-ma committed Dec 12, 2021
    Configuration menu
    Copy the full SHA
    89eb34e View commit details
    Browse the repository at this point in the history

  2. renamed AudioBufferSourceNodeOptions to AudioBufferSourceOptions … 

    …to be consistent with other nodes
    @b-ma
    b-ma committed Dec 12, 2021
    Configuration menu
    Copy the full SHA
    e8d07e6 View commit details
    Browse the repository at this point in the history

  3. AudioBufferSourcenode mvp

    @b-ma
    b-ma committed Dec 12, 2021
    Configuration menu
    Copy the full SHA
    1b9d5d2 View commit details
    Browse the repository at this point in the history

  4. pipe in gain

    @b-ma
    b-ma committed Dec 12, 2021
    Configuration menu
    Copy the full SHA
    45d7421 View commit details
    Browse the repository at this point in the history

  5. different style of examples

    @b-ma
    b-ma committed Dec 12, 2021
    Configuration menu
    Copy the full SHA
    2dea81a View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2021

  1. descent AudioBufferSourceNode

    @b-ma
    b-ma committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    1f96d3c View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2021

  1. implemented all AudioBufferSourceNode interface + cleaned examples

    @b-ma
    b-ma committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    2eaecd0 View commit details
    Browse the repository at this point in the history

  2. removed unused added code + fmt

    @b-ma
    b-ma committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    e84868b View commit details
    Browse the repository at this point in the history

  3. cleaned comments

    @b-ma
    b-ma committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    95868ee View commit details
    Browse the repository at this point in the history

  4. cleaned comments + fixed clippy

    @b-ma
    b-ma committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    5f468f4 View commit details
    Browse the repository at this point in the history

  5. fmt

    @b-ma
    b-ma committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    7d758ef View commit details
    Browse the repository at this point in the history

  6. fixed clippy (updated)

    @b-ma
    b-ma committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    f3e3610 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2021

  1. Implement forward/backward scrubbing example with original implementa… 

    …tion

It is very flawed:
- decode_audio_buffer does not exist yet so I need to put it in a media
  element
- this means I need to hardcode the buffer duration (3.0 seconds)
- since there's only 1 media element, I need to stop the previous scrub
  before I can start the next one. Causing clicks and a not nice sound
- something is off with the volume, I almost blew my eardrums out!
    @orottier
    orottier committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    a60ce47 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2021

  1. cleaned doc

    @b-ma
    b-ma committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    17a087d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feature/audio-buffer-source-node' of github.com:b-ma/we… 

    …b-audio-api-rs into feature/audio-buffer-source-node
    @b-ma
    b-ma committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    3ad5a5e View commit details
    Browse the repository at this point in the history

  3. moved decode_audio_data in BaseAudioContext + merged `audio_buffe… 

    …r` in `buffer`
    @b-ma
    b-ma committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    8ccabea View commit details
    Browse the repository at this point in the history

  4. test send buffer

    @b-ma
    b-ma committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    531aac5 View commit details
    Browse the repository at this point in the history

  5. cleaned and fixed doc examples

    @b-ma
    b-ma committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    2752872 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2021

  1. removed note

    @b-ma
    b-ma committed Dec 18, 2021
    Configuration menu
    Copy the full SHA
    3f5803c View commit details
    Browse the repository at this point in the history

  2. merged orottier:main + fixed conflicts

    @b-ma
    b-ma committed Dec 18, 2021
    Configuration menu
    Copy the full SHA
    a61c064 View commit details
    Browse the repository at this point in the history

  3. added "rust" tag to doc example

    @b-ma
    b-ma committed Dec 18, 2021
    Configuration menu
    Copy the full SHA
    4d8a252 View commit details
    Browse the repository at this point in the history

  4. no_run tag instead of rust

    @b-ma
    b-ma committed Dec 18, 2021
    Configuration menu
    Copy the full SHA
    fffa831 View commit details
    Browse the repository at this point in the history

  5. added AudioContext::create_buffer

    @b-ma
    b-ma committed Dec 18, 2021
    Configuration menu
    Copy the full SHA
    3767de5 View commit details
    Browse the repository at this point in the history

  6. doc for AudioContext::create_buffer

    @b-ma
    b-ma committed Dec 18, 2021
    Configuration menu
    Copy the full SHA
    1ef13c6 View commit details
    Browse the repository at this point in the history

  7. use array instead of Vec in copy_from_channel

    @b-ma
    b-ma committed Dec 18, 2021
    Configuration menu
    Copy the full SHA
    b0d4f03 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2021

  1. Merge remote-tracking branch 'upstream/main' into feature/audio-buffe… 

    …r-source-node
    @b-ma
    b-ma committed Dec 19, 2021
    Configuration menu
    Copy the full SHA
    836f06c View commit details
    Browse the repository at this point in the history

  2. passed ChannelData and AudioBuffer::from_channels to pub(crate)… 

    … + deleted bench.rs
    @b-ma
    b-ma committed Dec 19, 2021
    Configuration menu
    Copy the full SHA
    a95422d View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2021

  1. ChannelData is no longer public, add new constructor for AudioBuffer 

    and update test. Remove some unused stuff and fix docs
    @orottier
    orottier committed Dec 20, 2021
    Configuration menu
    Copy the full SHA
    e8eaeba View commit details
    Browse the repository at this point in the history

  2. cleaned doc and comments

    @b-ma
    b-ma committed Dec 20, 2021
    Configuration menu
    Copy the full SHA
    875f52f View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2021

  1. doc links

    @b-ma
    b-ma committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    3328b74 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2021

  1. Review changes: 

    - moved `offset` and `duration` in `Controller`
- make sure `offset` can't be outside range in `AudioBuffer::copy_from_channel` and `AudioBuffer::copy_to_channel`
- reintroduce `ChannelData::is_empty` with `#[allow(dead_code)]`
    @b-ma
    b-ma committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    d7139ca View commit details
    Browse the repository at this point in the history