-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working with bitcode_enabled NO flag #201
Comments
They should be accessible at runtime as plain keys, but I'd be surprised that they show up as raw values in the binaries though, the code in your app looks like this: https://github.com/orta/cocoapods-keys/blob/master/templates/Keys.m.erb#L36-L48 And never writes the raw values anywhere |
Here is the steps i am taking.
In screenshot attached you can see you can see the values in plain text. Altough last part has been chopped in sample project, In real project few of the keys are exposed without chopping. Let me know if you needs further information. |
Interesting, yeah, apple must have improved their compiler since I built this 6 years back, maybe it is inlining the string accessors in C now. I'm open to an alternative templates which don't have this issue 👍 - that could be as simple as ussing the NSString API instead of a c array or other alternatives |
OK, that's updated and shipped as 2.2.0 - great find @muddsar |
Great, Thanks again for the awesome fix guys :) |
@muddsar thank you for including such clear steps to reproduce! It made testing the fix really straightforward 👍 |
@ashfurrow you are welcome. Looks like your PR was merged in but release commit failed the pipeline :( i hope it will be resolved soon. |
@muddsar It looks like it's published here? I've been able to |
@ashfurrow Thanks for the correction, i was looking at the releases & tags in the repository. i tried the instructions you provided & it works like a charm. |
i am currently playing with Cocoapods-keys & observed that it doesn't work if bitcode_enabled is NO. values are embeded as plain text in Keys.Framework/Keys file. Can you please confirm if this is the expected behaviour?
The text was updated successfully, but these errors were encountered: