Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When clicked once, the story does not open in the simulator. #34

Closed
jbjeong-kosac opened this issue Sep 27, 2019 · 6 comments
Closed

When clicked once, the story does not open in the simulator. #34

jbjeong-kosac opened this issue Sep 27, 2019 · 6 comments

Comments

@jbjeong-kosac
Copy link

hello, I have a problem.

The Problem:

  • When clicked once, the story does not open in the simulator.

Env

  • React Native Storybook Vscode Extensions Version: 2.7.0
  • @Stroybook 버전: 5.2.1
  • VSCode Version: 1.38.1
  • Connected to stories(show the stories)
  • When clicked once, the story does not open in the simulator. (it is working, good)

How can I solve this problem?

@jb9229
Copy link

jb9229 commented Dec 1, 2019

@Manishalexin

Unfortunately, I haven't solved this problem yet.

Why didn't change the stories in emulator when click the story at VSCode? Could you help?

Env Info

Issue Video
• React Native Storybook extension of VSCode: 2.7.0
• Storybook package version: 5.2.7
• Web stories work well, only VSCode stories is not working(but changed selected source)

I want to use VSCode stories to change the story, how can I solve the problem?

@Manishalexin
Copy link
Contributor

@jb9229 It was published just that the version is somehow not incremented to the latest. So the fix is available in 2.6.1. I will create a PR with some more fixes so everything can be brought to the latest. Till then, use the 2.6.1 ( install other version option in VS Code plugins list ).

@ben-xD
Copy link

ben-xD commented Dec 24, 2019

Please release the small change as a patch change (2.7.1). The reason most people install this extension is for the simulator link. The latest version still does not work.

@jb9229
Copy link

jb9229 commented Dec 25, 2019

@ZenBoat Are there any other reasons not to use 2.6.1?
I have no big problem with that version yet

@ben-xD
Copy link

ben-xD commented Dec 25, 2019

No, 2.6.1 is working fine.

But new users will not install an older version; they would install 2.7.0, that is the version vscode would install. With the interest of not wasting new users time, the latest version should be working.

@orta
Copy link
Owner

orta commented Dec 26, 2019

Thanks folks - I' ve shipped 2.7.1 👍

@orta orta closed this as completed Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants