feat(push): adds build and push functionality into different subcommands #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpower432
force-pushed
the
feat/push-command
branch
from
6256b69
to
1778bec
Compare
jpower432
changed the title
jpower432
force-pushed
the
feat/push-command
branch
from
1e97483
to
773dedd
Compare
Closes ortelius#6 Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
Returning the descriptors allows for easier testing of concrete implementations of the Client interface and allows for post-processing on descriptors. Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
jpower432
force-pushed
the
feat/push-command
branch
from
f07d7af
to
ba47d49
Compare
sabre1041
requested changes
Jun 3, 2022
cli/build.go
Outdated
| # Template content in a directory and push to a registry location | ||
| client build <directory> --push --destination localhost:5000/myartifacts:latest | ||
| # Template content into a specified output directory. | ||
| client build mydirectory myoutputdirectory |
There was a problem hiding this comment.
Need to specify --output flag
cli/build.go
Outdated
| # Template content in a directory without pushing | ||
| client build <directory> | ||
| # Template content in a directory | ||
| client build mydirectory |
There was a problem hiding this comment.
Does this template the content from the specified directory into the current directory?
There was a problem hiding this comment.
There is a default workspace called "client-workspace" that is created in the current directory if the --ouput flag is not used. The content is taken from the specified directory and templated into that directory or whatever workspace is defined with the --output flag.
There was a problem hiding this comment.
Added that info the example text
cli/build.go
Outdated
| # Template content in a directory without pushing | ||
| client build <directory> | ||
| # Template content in a directory | ||
| client build mydirectory |
There was a problem hiding this comment.
In the output of the command, do we want to mention where the workspace directory is located?
There was a problem hiding this comment.
There is a log output at the end of the command that gives instructions on how to publish the rendered content with the workspace information. It is also logged at the beginning of the operation, but at the debug level. Do you think that is worth bumping to info?
There was a problem hiding this comment.
At this point, would like to lower the barrier of entry as much as possible, So recommend adding it at Info level
Co-authored-by: Andrew Block <andy.block@gmail.com>
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
jpower432
added a commit
to jpower432/client
that referenced
this pull request
Jun 21, 2022
…nds (ortelius#21) * feat(push): adds build and push functionality into different subcommands Closes ortelius#6 Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com> * docs: updates README.md with new usage directions for push Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com> * feat: changes Client interface to allow the descriptors be returned Returning the descriptors allows for easier testing of concrete implementations of the Client interface and allows for post-processing on descriptors. Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com> * chore: comment clean up in graph and builder packages Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com> * chore: update README.md with user workflow Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com> * test: adds artifact digest checking on build unit tests Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com> * chore: adds logger to push command Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com> * test(cli): adds logger to push e2e test Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com> * Update README.md Co-authored-by: Andrew Block <andy.block@gmail.com> * docs: adds correct output flags and fixes naming in examples Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com> * fix(build): bumps log about workspace to Info level in build command Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com> Co-authored-by: Andrew Block <andy.block@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6
Signed-off-by: Jennifer Power barnabei.jennifer@gmail.com