Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Like validate, for training use determine classes, train_label_infos from config_helper #171

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

KriWay
Copy link
Collaborator

@KriWay KriWay commented Mar 29, 2024

Depends on PR #168

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 73.41772% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 69.33%. Comparing base (c7f1c7b) to head (b42f321).
Report is 9 commits behind head on main.

Files Patch % Lines
orthoseg/validate.py 69.38% 15 Missing ⚠️
orthoseg/helpers/config_helper.py 76.92% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
+ Coverage   67.32%   69.33%   +2.01%     
==========================================
  Files          23       24       +1     
  Lines        3204     3258      +54     
==========================================
+ Hits         2157     2259     +102     
+ Misses       1047      999      -48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KriWay KriWay requested a review from theroggy March 29, 2024 07:28
Copy link
Collaborator

@theroggy theroggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR has become obsolete due to #172?

@theroggy theroggy marked this pull request as draft March 29, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants