fix special characters being removed #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oruelle
approved these changes
Feb 25, 2022
|
Don't forget to press on merge too :) |
|
woops, hold up, my later changes have also been added, we don't want that merged into your repo |
|
apologies for the mess/spam, I will never understand why they made git revert work the way it does... sigh |
|
Thank you, (I was surprised by the February 13 changes, thanks for the revert) |
|
Hello @oruelle , would you be so kinda and create a new release for the pip package? I use your extension in a CI/CD pipeline and would like to pull these changes via pip. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to solve #2
As it was not clear to me why this was introduced, I cannot be sure that this won't break its intended purpose.
But this code can create a very basic mermaid diagram, and it preserves the special characters.
I made sure it still does the cleaning step on the mermaid block, but it skips removing non-printables when it's outside of a mermaid block.
I'd appreciate it if you could accept this pull request / create your own fix. This package is a really nice drop-in solution for generating mermaid diagrams, and we would like to just include it directly, instead of via a fork.