Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Loading Component the label prop #608

Closed
Diogo-Coding opened this issue Oct 4, 2023 · 4 comments · Fixed by #622
Closed

Add Loading Component the label prop #608

Diogo-Coding opened this issue Oct 4, 2023 · 4 comments · Fixed by #622
Assignees
Labels
enhancement Improvements to existing features and functionality

Comments

@Diogo-Coding
Copy link

Description

Add text to Loading component via prop, to show a small text about the loading

Normally, to tell users whats going on you need to show them more information, like 'Creating chat' instead of just show an icon

Why Oruga need this feature

User experience

@mlmoravek mlmoravek added the enhancement Improvements to existing features and functionality label Oct 5, 2023
@mlmoravek mlmoravek self-assigned this Oct 5, 2023
@jtommy
Copy link
Member

jtommy commented Oct 10, 2023

@Diogo-Coding do you mean using it programmatically?

@Diogo-Coding
Copy link
Author

Diogo-Coding commented Oct 10, 2023

@jtommy Either of both ways could be good tbh

@mlmoravek
Copy link
Member

mlmoravek commented Oct 10, 2023

I added a label prop to the component, which will display a test next to the icon. I also added a new style class for the label span element to style the label.
Themes have to be updated later on.

@jtommy
Copy link
Member

jtommy commented Oct 10, 2023

@jtommy Either of both ways could be good tbh

Then you can use the slot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to existing features and functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants