Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update loading | adjust notification component #622

Merged
merged 4 commits into from
Oct 11, 2023

Conversation

mlmoravek
Copy link
Member

This is part of #606

In this PR I refactored the loading component from Options-API to Composition-API.

Fixes #608

Proposed Changes

  • Update Loading to composition api
  • Add label prop to notification component
  • Update docs
  • Adjust Notification component

@mlmoravek mlmoravek added enhancement Improvements to existing features and functionality breaking Breaking changes refactoring This involves some refactoring of existing code. labels Oct 10, 2023
@mlmoravek mlmoravek self-assigned this Oct 10, 2023
@netlify
Copy link

netlify bot commented Oct 10, 2023

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit dff1e18
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/652662f4be4c9900080962c7
😎 Deploy Preview https://deploy-preview-622--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mlmoravek mlmoravek changed the title Update loading refactor: update loading | adjust notification Oct 10, 2023
@mlmoravek mlmoravek changed the title refactor: update loading | adjust notification refactor: update loading | adjust notification component Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (6da9426) 63.89% compared to head (dff1e18) 63.39%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #622      +/-   ##
===========================================
- Coverage    63.89%   63.39%   -0.50%     
===========================================
  Files           85       86       +1     
  Lines         5495     5532      +37     
  Branches      1561     1566       +5     
===========================================
- Hits          3511     3507       -4     
- Misses        1873     1914      +41     
  Partials       111      111              
Flag Coverage Δ
oruga 65.92% <ø> (ø)
oruga-next 51.99% <ø> (-2.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlmoravek mlmoravek merged commit 860d083 into oruga-ui:develop Oct 11, 2023
9 of 11 checks passed
@mlmoravek mlmoravek deleted the update-loading branch October 11, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes enhancement Improvements to existing features and functionality refactoring This involves some refactoring of existing code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Loading Component the label prop
1 participant