Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkable Table do not store the row when individual row is checked #81

Closed
QuentinGab opened this issue Feb 3, 2021 · 2 comments · Fixed by #82
Closed

Checkable Table do not store the row when individual row is checked #81

QuentinGab opened this issue Feb 3, 2021 · 2 comments · Fixed by #82
Assignees
@astagi
Labels
bug Something isn't working

Comments

@QuentinGab
Copy link

QuentinGab commented Feb 3, 2021 •
edited

Overview of the problem

Just reproduce it here: https://oruga.io/components/Table.html#checkable
Browser:

  • Edge: v88.0.705.56
  • Chrome: v88.0.4324.104

Description

When a single row is checked, the row is not pushed to checkedRows so it does not sync it at all (Total checked do not change)
However when bulk rows are checked it works as expected.

Steps to reproduce

Just reproduce it here: https://oruga.io/components/Table.html#checkable

Capture

(Thx for your amazing work)
@astagi
Copy link
Member

astagi commented Feb 3, 2021

Hey @QuentinGab thanks for reporting the issue! We'll check it asap and release a minfix version when fixed!

@astagi astagi added the bug Something isn't working label Feb 3, 2021
@astagi astagi self-assigned this Feb 3, 2021
astagi added a commit that referenced this issue Feb 4, 2021
@astagi
Use input instead of native click for table checkboxes. Fixes #81
3813f87
@astagi astagi mentioned this issue Feb 4, 2021
Merged
@jtommy jtommy closed this as completed in #82 Feb 4, 2021
jtommy added a commit that referenced this issue Feb 4, 2021
@jtommy
Merge pull request #82 from oruga-ui/hotfix/81
91d5edf 
Use input instead of native click for table checkboxes. Fixes #81
@astagi
Copy link
Member

astagi commented Feb 6, 2021

@QuentinGab release 0.3.2 with this fix is now available on npm!

npm i @oruga-ui/oruga@0.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@astagi astagi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use input instead of native click for table checkboxes. Fixes #81 oruga-ui/oruga
2 participants
@astagi @QuentinGab