Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(carousel): update component #621

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

mlmoravek
Copy link
Member

This is part of #606

In this PR I refactored the carousel component from Options-API to Composition-API.

Proposed Changes

  • Updated Carousel to composition api
  • Refactor InjectChildMixin and ProvideParentMixin into composable
  • update docs

@mlmoravek mlmoravek added breaking Breaking changes refactoring This involves some refactoring of existing code. labels Oct 10, 2023
@mlmoravek mlmoravek self-assigned this Oct 10, 2023
@netlify
Copy link

netlify bot commented Oct 10, 2023

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit 1d6e980
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/6526616dbe4c9900080918a2
😎 Deploy Preview https://deploy-preview-621--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (6da9426) 63.89% compared to head (1d6e980) 63.48%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #621      +/-   ##
===========================================
- Coverage    63.89%   63.48%   -0.41%     
===========================================
  Files           85       86       +1     
  Lines         5495     5532      +37     
  Branches      1561     1566       +5     
===========================================
+ Hits          3511     3512       +1     
- Misses        1873     1909      +36     
  Partials       111      111              
Flag Coverage Δ
oruga 65.92% <ø> (ø)
oruga-next 52.49% <0.00%> (-1.91%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...es/oruga-next/src/composables/useParentProvider.ts 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlmoravek mlmoravek changed the title refactor: update carousel component refactor(carousel): update component Oct 11, 2023
@mlmoravek mlmoravek merged commit c7da2d8 into oruga-ui:develop Oct 11, 2023
8 of 11 checks passed
@mlmoravek mlmoravek deleted the refactor-carousel branch October 11, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes refactoring This involves some refactoring of existing code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant