Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update modal | add useProgrammatic composable #623

Merged
merged 17 commits into from
Oct 15, 2023

Conversation

mlmoravek
Copy link
Member

@mlmoravek mlmoravek commented Oct 11, 2023

This is part of #606

In this PR, I refactored the modal component from the Options API to the Composition API.
I also extracted the programmatic functionality into a componsable.

Fixes #568
Fixes #334

Proposed Changes

@mlmoravek mlmoravek added breaking Breaking changes refactoring This involves some refactoring of existing code. labels Oct 11, 2023
@mlmoravek mlmoravek self-assigned this Oct 11, 2023
@netlify
Copy link

netlify bot commented Oct 11, 2023

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit 71162a8
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/652bad2b2bf9860008d08ec7
😎 Deploy Preview https://deploy-preview-623--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 55 lines in your changes are missing coverage. Please review.

Comparison is base (4d8d58f) 63.39% compared to head (71162a8) 62.77%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #623      +/-   ##
===========================================
- Coverage    63.39%   62.77%   -0.63%     
===========================================
  Files           86       87       +1     
  Lines         5532     5587      +55     
  Branches      1566     1590      +24     
===========================================
  Hits          3507     3507              
- Misses        1914     1969      +55     
  Partials       111      111              
Flag Coverage Δ
oruga 65.92% <ø> (ø)
oruga-next 49.29% <0.00%> (-2.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ages/oruga-next/src/composables/useProgrammatic.ts 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlmoravek mlmoravek merged commit fd7f324 into oruga-ui:develop Oct 15, 2023
8 of 11 checks passed
@mlmoravek mlmoravek deleted the refactor-modal branch October 15, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes refactoring This involves some refactoring of existing code.
Projects
None yet
1 participant