Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tooltip #631

Merged
merged 5 commits into from
Oct 18, 2023
Merged

Refactor tooltip #631

merged 5 commits into from
Oct 18, 2023

Conversation

mlmoravek
Copy link
Member

This is part of #606

In this PR, I refactored the tooltip component from the Options API to the Composition API.

Proposed Changes

  • Update Tooltip to composition api
  • Update docs

@mlmoravek mlmoravek added the refactoring This involves some refactoring of existing code. label Oct 17, 2023
@mlmoravek mlmoravek self-assigned this Oct 17, 2023
@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit d2d59d0
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/652e8203fff5ec00086348a1
😎 Deploy Preview https://deploy-preview-631--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (922f880) 62.71% compared to head (d2d59d0) 62.62%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #631      +/-   ##
===========================================
- Coverage    62.71%   62.62%   -0.09%     
===========================================
  Files           87       87              
  Lines         5598     5598              
  Branches      1595     1595              
===========================================
- Hits          3511     3506       -5     
- Misses        1976     1981       +5     
  Partials       111      111              
Flag Coverage Δ
oruga 65.92% <ø> (ø)
oruga-next 48.69% <ø> (-0.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlmoravek mlmoravek merged commit ee68e5b into oruga-ui:develop Oct 18, 2023
9 of 11 checks passed
@mlmoravek mlmoravek deleted the refactor-tooltip branch October 18, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring This involves some refactoring of existing code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant