Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve maximum recursive update exceeded in tests #869

Merged
merged 4 commits into from
Mar 27, 2024

Conversation

mlmoravek
Copy link
Member

@mlmoravek mlmoravek commented Mar 26, 2024

Fixes #854

Proposed Changes

  • resolve maximum recursive update exceeded in PositionWrapper
  • adjust Dropdown & Tooltip

@mlmoravek mlmoravek added the bug Something isn't working label Mar 26, 2024
Copy link

netlify bot commented Mar 26, 2024

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit 8d93bae
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/66042768d1a7180008108646
😎 Deploy Preview https://deploy-preview-869--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 10.62%. Comparing base (484cfe8) to head (fe14814).
Report is 31 commits behind head on develop.

❗ Current head fe14814 differs from pull request most recent head 8d93bae. Consider uploading reports for the commit 8d93bae to get more accurate results

Files Patch % Lines
...ges/oruga/src/components/utils/PositionWrapper.vue 82.35% 2 Missing and 1 partial ⚠️
...ackages/oruga/src/composables/useParentProvider.ts 0.00% 3 Missing ⚠️
packages/oruga/src/components/tooltip/Tooltip.vue 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #869       +/-   ##
============================================
- Coverage    56.71%   10.62%   -46.10%     
============================================
  Files           30      110       +80     
  Lines         1511     5282     +3771     
  Branches       544     1917     +1373     
============================================
- Hits           857      561      -296     
- Misses         654     3743     +3089     
- Partials         0      978      +978     
Flag Coverage Δ
oruga-next 10.62% <66.66%> (-46.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlmoravek mlmoravek merged commit 40d8b94 into oruga-ui:develop Mar 27, 2024
7 checks passed
@mlmoravek mlmoravek deleted the fix/tests-max-recursive-updates branch March 27, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests: Maximum recursive updates exceeded in component <ODropdown>
1 participant