Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabs): fix disable animation #870

Merged

Conversation

messenjer
Copy link
Contributor

Fixes #863

Proposed Changes

Replace disabled by css, the prop to disable transition is css https://vuejs.org/api/built-in-components.html#transition

Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit e58670e
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/660528b2f30c6d00078535d8
😎 Deploy Preview https://deploy-preview-870--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.62%. Comparing base (484cfe8) to head (6748f19).
Report is 32 commits behind head on develop.

❗ Current head 6748f19 differs from pull request most recent head e58670e. Consider uploading reports for the commit e58670e to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #870       +/-   ##
============================================
- Coverage    56.71%   10.62%   -46.10%     
============================================
  Files           30      110       +80     
  Lines         1511     5281     +3770     
  Branches       544     1916     +1372     
============================================
- Hits           857      561      -296     
- Misses         654     3743     +3089     
- Partials         0      977      +977     
Flag Coverage Δ
oruga-next 10.62% <ø> (-46.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@messenjer
Copy link
Contributor Author

I fixed also the same issue in the StepItem component : e58670e

@mlmoravek mlmoravek added the bug Something isn't working label Mar 28, 2024
@mlmoravek mlmoravek merged commit 08c1fbf into oruga-ui:develop Mar 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to disable animation on Tabs component
2 participants