core: add start()/stop() #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support the ability to start and stop containers, which is a useful way of testing certain failure modes.
|
that's pretty cool, I'll review it tomorrow when I'm not so tired any more ;) |
|
Sounds good, thanks for the quick reply! Also looking at the PR builder failure. I've narrowed it down to this commit in glide: Using glide at a version before that commit seems to have no issues. |
|
Submitted a fix: Masterminds/glide#559 |
|
Could you add an example for this in the README.md, so people know about the feature? You could also document best practice for dealing with this. |
mfycheng
force-pushed
the
add-startstop
branch
from
7da219a
to
26402c9
Compare
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Used ZooKeeper to test Start()/Stop(), since it's already in the integration test, and was an easy way to verify that the container was stopped / restarted.