Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How about use go-dockerclient ? #11

Closed
clongbupt opened this issue Nov 4, 2015 · 4 comments
Closed

How about use go-dockerclient ? #11

clongbupt opened this issue Nov 4, 2015 · 4 comments

Comments

@clongbupt
Copy link

Just found this repo, it is easy to do a integration test with postgres for golang project.

How about using some golang dockerclient instead of wrapping docker cli and parsing byte output ?

@aeneasr
Copy link
Member

aeneasr commented Nov 4, 2015

Good point, docker-machine unfortunately has no go bindings yet which is why this was originally written using the CLI along with the fact that this repo is forked from Camlistore who use the CLI as well. However it might be smarter to detect if docker-machine is available, boot it (which currently causes issues sometimes) and pass the env vars to go-dockerclient or dockerclient.

If no issues arise from using the CLI instead of bindings/APIs, I'd flag this as nice-to-have/low-prio. Do you agree?

@clongbupt
Copy link
Author

Okk. I know the reason.

@aeneasr
Copy link
Member

aeneasr commented Nov 4, 2015

Cool, thanks for bringing your thoughts to the project!

@aeneasr
Copy link
Member

aeneasr commented May 17, 2016

You can now do this with #46 and following

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants