Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs refresh bug #563

Closed
vinckr opened this issue Aug 17, 2020 · 6 comments
Closed

docs refresh bug #563

vinckr opened this issue Aug 17, 2020 · 6 comments
Assignees

Comments

@vinckr
Copy link
Member

vinckr commented Aug 17, 2020

Describe the bug

If I go to Zero Trust with IAP Proxy and scroll down to #cookie-session-authenticator and click the link "to ORY Kratos' /sessions/whoami API."
Then everything works correctly and I end up at https://www.ory.sh/kratos/docs/reference/api/
But if I reload the page now and click the same link again, I get routed to : https://www.ory.sh/kratos/docs/guides/reference/api and get a 404.

Reproducing the bug
Go to "https://www.ory.sh/kratos/docs/guides/zero-trust-iap-proxy-identity-access-proxy"
if you reload the page it turns into: "https://www.ory.sh/kratos/docs/guides/zero-trust-iap-proxy-identity-access-proxy/"
Click the link at https://www.ory.sh/kratos/docs/guides/zero-trust-iap-proxy-identity-access-proxy/#cookie-session-authenticator.
You get redirected to 404.

Expected behavior
I should end up at https://www.ory.sh/kratos/docs/reference/api/.
But if I reload the page I get routed to : https://www.ory.sh/kratos/docs/guides/reference/api and get a 404.

Additional context

This seems to stem from the / that is added to the URL after the reload.

@aeneasr aeneasr transferred this issue from ory/kratos Aug 17, 2020
@aeneasr aeneasr self-assigned this Nov 18, 2020
@aeneasr
Copy link
Member

aeneasr commented Nov 20, 2020

I can not reproduce this any more, I think we have resolved issues with trailing slashes!

@aeneasr aeneasr closed this as completed Nov 20, 2020
@vinckr
Copy link
Member Author

vinckr commented Jan 11, 2021

For me the issue is still there @aeneasr
I just searched something via google, got sent to:
https://www.ory.sh/hydra/docs/jwks/
and the links to reference API are broken
because of the added trailing slash.

When I leave and re-enter the page through the navbar everything works correctly.

The issue only comes up when you come to the docs from an outside link like google ect.
Its not terrible, just wanted to record it.

@aeneasr
Copy link
Member

aeneasr commented Jan 15, 2021

@vinckr I believe the problem is that the link does not include the .md or .mdx filename so docusaurus thinks we're linking to a randomg page, not to a document. If you find these links - search for the filename (e.g. api.md) and add the appendix. Please document this in ory/docs as part of "contributing -> how to write documentation -> how to add links to other docs pages"

@aeneasr aeneasr reopened this Jan 15, 2021
@vinckr
Copy link
Member Author

vinckr commented Jan 15, 2021

Sounds reasonable. I will add some info on that. I will go over the links.

@aeneasr aeneasr assigned vinckr and unassigned aeneasr Jan 15, 2021
@vinckr
Copy link
Member Author

vinckr commented Jan 20, 2021

What also results in 404

The way to browse the docs safely, is to use the sidebar navigation.

Seems like the same issue, but I have no idea how to fix it.

@aeneasr aeneasr transferred this issue from ory/docusaurus-template Feb 10, 2022
@vinckr
Copy link
Member Author

vinckr commented Feb 21, 2022

This also seems to be fixed, was not able to reproduce it in the above cases.
If it crops up again, we can fix it with by adding the .md etc. extensions

@vinckr vinckr closed this as completed Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants