Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Contributing Examples #26

Closed
vinckr opened this issue Jun 15, 2022 · 3 comments
Closed

Document Contributing Examples #26

vinckr opened this issue Jun 15, 2022 · 3 comments

Comments

@vinckr
Copy link
Member

vinckr commented Jun 15, 2022

We should add documentation how to contribute new examples.

Draft PR: #25

We can add a short section to the README or add it to the general template CONTRIBUTING doc or write a seperate CONTRIBUTING for this repo, what do you think @kevgo ?

@kevgo
Copy link
Contributor

kevgo commented Jun 21, 2022

The general breakup I use for documentation is:

  • README.md is for end users. It describes the features, how to install, how to start
  • DEVELOPMENT.md is for developers: how to hack on this, how to run tests, where is which code
  • CONTRIBUTING.md is for contributors, i.e. developers who contribute their modifications back. It is shown when making the first PR and states needed legalese like "Before we can accept this code from you, you have to agree to our COC and CLA".

So, my vote on where to put this goes to DEVELOPMENT.md.

@vinckr
Copy link
Member Author

vinckr commented Jun 23, 2022

Sorry for going over you here Kevin,
but I went ahead and added a short section to the general contributing template, that is copied to all repos. I had to move a bit fast to get the word out, but we can still think of improvements down the line.

While I think your distinction makes sense, I dont see why it would be in the DEVELOPMENT.md in this case - this is explicitly a guide how to contribute examples. I think all legalities are covered by our contributor license agreement.

IMO CONTRIBUTING.md should cover everything that is useful to people who want to contribute - long before they open the first pull request CONTRIBUTING shows the conduct and general process of contributions. Most importantly IMO it also outlines all the ways that you can contribute without ever writing a line of code or opening a PR.

Closing since the initial issue is resolved, and subsequent improvements to the doc would best be discussed in ory/meta

@vinckr vinckr closed this as completed Jun 23, 2022
@kevgo
Copy link
Contributor

kevgo commented Jun 25, 2022

No worries, there are many correct answers here. That was just my take on it. You make an excellent point that CONTRIBUTING.md is a natural place where people look for how to contribute examples. Good choice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants