Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return request unauthorized error on invalid password credentials #261

Merged
merged 2 commits into from
Apr 23, 2018
Merged

Return request unauthorized error on invalid password credentials #261

merged 2 commits into from
Apr 23, 2018

Conversation

beornf
Copy link
Contributor

@beornf beornf commented Apr 23, 2018

The error return code for invalid password credentials seems better suited to a 401 request unauthorized.

@beornf
Return request unauthorized error on invalid password credentials
daf0c4d 
Signed-off-by: Beorn Facchini <beorn@lade.io>
@coveralls
Copy link

coveralls commented Apr 23, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 85.486% when pulling db3b114 on beornf:password-credentials-unauthorized into 0fcdf33 on ory:master.

@aeneasr
Copy link
Member

aeneasr commented Apr 23, 2018

That makes sense, thanks!

@aeneasr aeneasr merged commit cca6af4 into ory:master Apr 23, 2018
budougumi0617 added a commit to budougumi0617/fosite that referenced this pull request May 10, 2019
@budougumi0617
handler/oauth2: Returns request unauthorized error on invalid passwor…
71417a8 
…d credentials (ory#261)

Signed-off-by: Beorn Facchini <beorn@lade.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@beornf @coveralls @aeneasr