refactor: fix inconsistent spelling of revocation #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-davis
commented
Sep 14, 2020
| @@ -243,7 +243,7 @@ const ( | |||
| errTokenInactiveName = "token_inactive" | |||
| // errAuthorizaionCodeInactiveName = "authorization_code_inactive" | |||
| errUnknownErrorName = "error" | |||
| errRevokationClientMismatchName = "revokation_client_mismatch" | |||
| errRevocationClientMismatchName = "revocation_client_mismatch" | |||
There was a problem hiding this comment.
Will this spelling change cause some externally-observable difference?
e.g. does revocation_client_mismatch get returned to consumers of this package...
aeneasr
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Not applicable
Proposed changes
"revocation" is also spelled "revokation" in various place. Make it consistent - "revocation".
This changes some constant and/or variable names in the code, so I have made this a "refactor" PR.
Checklist
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
Further comments