Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sha alg name in error message and go doc #571

Merged
merged 4 commits into from
Mar 29, 2021
Merged

fix: sha alg name in error message and go doc #571

merged 4 commits into from
Mar 29, 2021

Conversation

vineet-garg
Copy link
Contributor

@vineet-garg vineet-garg commented Mar 28, 2021 •
edited
Loading

Related issue

N/A

Proposed changes

Update the messages and document with new algorithm name. The algorithm was changed earlier and it seems the references were not updated.

Checklist

  • [ x] I have read the contributing guidelines
    and signed the CLA.
  • [ x] I have read the security policy.
  • [x ] I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • [x ] I have added necessary documentation within the code base (if
    appropriate).

Further comments

@CLAassistant
Copy link

CLAassistant commented Mar 28, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@vineet-garg vineet-garg changed the title Fix sha alg name in error message and go doc fix: sha alg name in error message and go doc Mar 28, 2021
@vineet-garg vineet-garg marked this pull request as ready for review March 28, 2021 01:16
aeneasr
aeneasr requested changes Mar 29, 2021
View reviewed changes
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for your contribution! This looks pretty good and I have some ideas how to improve it further :)

token/hmac/hmacsha.go Outdated Show resolved Hide resolved
vineet-garg and others added 2 commits March 29, 2021 02:15
@vineet-garg @aeneasr
standard name for having algorithm
163f9ae 
Co-authored-by: hackerman <3372410+aeneasr@users.noreply.github.com>
@vineet-garg
updated sha algorithm name in more error messages.
737ed3b
aeneasr
aeneasr approved these changes Mar 29, 2021
View reviewed changes
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! 🎉 Your contribution makes Ory better :)

@aeneasr aeneasr merged commit 0f2e289 into ory:master Mar 29, 2021
@vineet-garg
Copy link
Contributor Author

Awesome, thank you! 🎉 Your contribution makes Ory better :)

Thank you!

@aeneasr
Copy link
Member

aeneasr commented Mar 29, 2021

Looks like I overlooked the test failure, could you please fix the test?

https://app.circleci.com/pipelines/github/ory/fosite/352/workflows/0432cd13-c765-46d7-85dd-e7daea1748d1/jobs/1111

Thank you!

@vineet-garg
Copy link
Contributor Author

Looks like I overlooked the test failure, could you please fix the test?

https://app.circleci.com/pipelines/github/ory/fosite/352/workflows/0432cd13-c765-46d7-85dd-e7daea1748d1/jobs/1111

Thank you!

absolutely, I have a new PR, I will include in that now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeneasr aeneasr aeneasr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vineet-garg @CLAassistant @aeneasr