-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ResponseModeHandler to support custom response modes #592
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is going in the right direction! Would definitely need a few more tests, especially integration tests :)
sure, bu I was thinking in unit tests, why did you consider integration tests if this change is not integrating with a DB or external processes, or what kind of integration tests you mean? Can you point me in the right direction? |
Ah sure, I was thinking of a test in the direction of https://github.com/ory/fosite/blob/master/integration/authorize_form_post_test.go which would use a custom response mode. Does that make sense? |
Sure, makes sense, I will use it as a base |
6680612
to
6b8272f
Compare
@aeneasr done! Let me know if that would be enough to merge this PR |
6b8272f
to
21404a2
Compare
Once ory/hydra#2526 is merged we can re-run the conformity tests here which should then pass :) |
21404a2
to
d586575
Compare
@aeneasr today's merged commits in hydra and fosite seem to work :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you for your contribution!
Related issue
#591
Proposed changes
This is a draft/preview PR of the proposed change described in issue #591
Status
ResponseModeHandler
incompose.Config
packageChecklist
and signed the CLA.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
appropriate).