feat: Support FormPostHTMLTemplate config for fosite #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonywang-eth
changed the title
This comment has been minimized.
This comment has been minimized.
aeneasr
requested changes
Jan 31, 2022
mitar
reviewed
Jan 31, 2022
| @@ -74,6 +74,7 @@ func Compose(config *Config, storage interface{}, strategy interface{}, hasher f | |||
| ClientAuthenticationStrategy: config.GetClientAuthenticationStrategy(), | |||
| ResponseModeHandlerExtension: config.ResponseModeHandlerExtension, | |||
| MessageCatalog: config.MessageCatalog, | |||
| FormPostHTMLTemplate: config.FormPostHTMLTemplate, | |||
There was a problem hiding this comment.
I think it is being used here?
Line 114 in cf02af9
There was a problem hiding this comment.
You're right, I thought that was also an addition, but it's not. Thank you, LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support FormPostHTMLTemplate configuration during fosite init phase
Related Issue or Design Document
#646
Checklist
and signed the CLA.
introduces a new feature.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
appropriate).
Further comments