Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated: jwt-go is now v3.0.0. #77

Merged
merged 1 commit into from
Aug 22, 2016
Merged

Updated: jwt-go is now v3.0.0. #77

merged 1 commit into from
Aug 22, 2016

Conversation

leetal
Copy link
Contributor

@leetal leetal commented Aug 22, 2016

This PR is in direct response to #76.

NOTE:
No direct breaking API changes should have been introduced in this pull request, as long as no one explicitly uses the raw values of "iat", "exp" and "nbf" claims (was int, is now float). This is due to the fact that jwt-go needs float64 types when validating the claims. I will create a new PR to jwt-go as well that is going to allow int64 values to be parsed. Hopefully it will get merged fast. If that's the case, after a minor upgrade to fosite removing the float64 casts, nothing API-wise will have changed since before the upgrade to jwt-go 3.0.0.

// Alex

… any BCs.

Signed-off-by: Alexander Widerberg <alexander.widerberg@cybercom.com>
@leetal
Copy link
Contributor Author

leetal commented Aug 22, 2016

I have supplied a PR to jwt-go now that will fix the "float" issue. Now it is up to them to decide whether or not to merge it.

@aeneasr
Copy link
Member

aeneasr commented Aug 22, 2016

Hey @leetal thanks for this! Float64 indeed makes sense because javascript is using 64bit floats always. I think it's ok to increase the minor version with this PR.

Let me know if you want to wait for jwt-go to be merged or just merge this directly and release a new version. Both work for me.

@aeneasr aeneasr added the feat New feature or request. label Aug 22, 2016
@aeneasr aeneasr self-assigned this Aug 22, 2016
@leetal
Copy link
Contributor Author

leetal commented Aug 22, 2016

Yeah, I think it is OK for now. It's a later discussion whether or not to
change back to int64. For now it will probably work for more or less
everyone, even if someone actually is using the raw values or not.
It will probably be a while until jwt-go merge the change. If ever.. ;)

@otraore
Copy link

otraore commented Aug 22, 2016

Looking forward to seeing this merged in, gives me a reminder I have to update to the new jwt-go api on some personal projects

@aeneasr
Copy link
Member

aeneasr commented Aug 22, 2016

Ok, thanks for the hard work!

@aeneasr aeneasr merged commit 76ef7ea into ory:master Aug 22, 2016
budougumi0617 added a commit to budougumi0617/fosite that referenced this pull request May 10, 2019
Signed-off-by: Alexander Widerberg <alexander.widerberg@cybercom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants