Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key rotation CLI message is unclear how to use ROTATED_SYSTEM_SECRET #1187

Closed
paxswill opened this issue Nov 25, 2018 · 2 comments
Closed

Key rotation CLI message is unclear how to use ROTATED_SYSTEM_SECRET #1187

paxswill opened this issue Nov 25, 2018 · 2 comments

Comments

@paxswill
Copy link

The docs say that ROTATED_SYSTEM_SECRET should be set to the old system secret, but the output of hydra migrate secret says to set it to the new secret. Is /cmd/cli/handler_migrate.go#L144 supposed to be newSecret and the documentation updated, or is the documentation correct and it's supposed to be oldSecret?
@aeneasr
Copy link
Member

aeneasr commented Nov 26, 2018 •
edited

Nice catch, that should be oldSecret and set to old secret in handler_migrate.go

@prateek1192 prateek1192 mentioned this issue Nov 30, 2018
Merged
6 tasks
@paxswill
Copy link
Author

paxswill commented Dec 8, 2018

Closing, resolved by #1195

@paxswill paxswill closed this as completed Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paxswill @aeneasr