Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth Client authentication creation CLI jwks client field not present #1404

Closed
ProMPT120 opened this issue Apr 30, 2019 · 4 comments
Closed
Labels
feat New feature or request. stale Feedback from one or more authors is required to proceed.
Milestone

Comments

@ProMPT120
Copy link

ProMPT120 commented Apr 30, 2019

Describe the bug
A clear and concise description of what the bug is.
The hydra client doesn't allow to specify the jwks field to set the client jwks field in hydra CLI. The CLI does present jwks-uri however. The client is forced to use the REST API for now when using this feature.

To Reproduce
Steps to reproduce the behavior:

  1. Run hydra clients create --endpoint https://redacted.io/hydra-admin/ --id aaaa -n aaap-aaa -a system:aaaa:client:create --token-endpoint-auth-method "private_key_jwt" -g client_credentials --jwks $(< pub_jwks.json)
    Error from client :
    unknown flag : --jwks

Expected behavior
The hydra client does include --jwks-uri but not the expected field --jwks as mentionned.
https://www.ory.sh/docs/hydra/advanced
"To enable this feature for a specific OAuth 2.0 Client, you must set token_endpoint_auth_method to private_key_jwt and register the public key of the RSA signing key either using the jwks_uri or jwks fields of the client."

Screenshots
If applicable, add screenshots to help explain your problem.

Version:
Latest client and Hydra backend

@aeneasr
Copy link
Member

aeneasr commented Apr 30, 2019

Yeah that's missing - jwks-uri is supported using the cli only atm. Would you be open to create a PR? I think it should be straight forward!

@aeneasr aeneasr added this to the v1.0.1 milestone Apr 30, 2019
@aeneasr aeneasr added the feat New feature or request. label Apr 30, 2019
@ProMPT120
Copy link
Author

I will check if everything works correctly with the jwks client first, then i will check for a PR on this. To simplify adequation with CLI and not forced to template with REST and have to maintain the custom templates.

@aeneasr aeneasr modified the milestones: v1.0.1, v1.1.0 Oct 2, 2019
@aeneasr aeneasr modified the milestones: v1.1.0, v1.3.0 Feb 3, 2020
@aeneasr aeneasr modified the milestones: v1.4.0, v1.5.0 Apr 23, 2020
@aeneasr aeneasr modified the milestones: v1.5.0, v1.6.0 Jul 1, 2020
@aeneasr aeneasr modified the milestones: v1.6.0, v1.8.0 Aug 4, 2020
@github-actions
Copy link

I am marking this issue as stale as it has not received any engagement from the community or maintainers in over half a year. That does not imply that the issue has no merit! If you feel strongly about this issue

  • open a PR referencing and resolving the issue;
  • leave a comment on it and discuss ideas how you could contribute towards resolving it;
  • open a new issue with updated details and a plan on resolving the issue.

We are cleaning up issues every now and then, primarily to keep the 4000+ issues in our backlog in check and to prevent maintainer burnout. Burnout in open source maintainership is a widespread and serious issue. It can lead to severe personal and health issues as well as enabling catastrophic attack vectors.

Thank you for your understanding and to anyone who participated in the issue! 🙏✌️

If you feel strongly about this issues and have ideas on resolving it, please comment. Otherwise it will be closed in 30 days!

@github-actions github-actions bot added the stale Feedback from one or more authors is required to proceed. label Sep 21, 2021
@mitar
Copy link
Contributor

mitar commented Mar 4, 2022

Please reopen this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request. stale Feedback from one or more authors is required to proceed.
Projects
None yet
Development

No branches or pull requests

3 participants