Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add packr2 steps in Makefile #1858

Merged
merged 2 commits into from
May 16, 2020
Merged

fix: add packr2 steps in Makefile #1858

merged 2 commits into from
May 16, 2020

Conversation

arapaho
Copy link
Contributor

@arapaho arapaho commented May 16, 2020

Related issue

Closes #1857

Proposed changes

Fix the build from source by adding packr2 steps.

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further comments

packr2 binary is a needed pre-requisite used to generate .go files that
pack the static files of the project into bytes that can be bundled.
Invokes packr2 in install-stable and install targets of Makefile in
order to generate the .go files that pack the static files into bytes
that can be bundled.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@arapaho arapaho changed the title Add packr2 steps in Makefile fix: add packr2 steps in Makefile May 16, 2020
@aeneasr
Copy link
Member

aeneasr commented May 16, 2020

Thank you!

@aeneasr aeneasr merged commit 08ac026 into ory:master May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building from sources miss packr2 steps
3 participants