Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update examples to new helm install command format #2369

Merged
merged 2 commits into from
Mar 1, 2021

Conversation

humb1t
Copy link
Contributor

@humb1t humb1t commented Feb 24, 2021

Proposed changes

Tried example with helm 3.5.2 and it does not support --name flag. So I moved name and repository to first line of commands.

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Tried example with helm 3.5.2 and it does not support `--name` flag. So I moved name and repository to first line of commands.
@CLAassistant
Copy link

CLAassistant commented Feb 24, 2021

CLA assistant check
All committers have signed the CLA.

@humb1t humb1t changed the title doc: update examples to new helm install command format docs: update examples to new helm install command format Feb 24, 2021
@aeneasr
Copy link
Member

aeneasr commented Feb 27, 2021

Thank you very much for your contribution to the documentation! Due to the way Docusaurus versioning works, you need to make the changes in two locations:

  • docs/versioned_docs/version-v{version}/path/to/file
  • docs/docs/path/to/file

Without making them in both locations, the changes will most likely be lost when releasing another version. Thank you! :)

@aeneasr aeneasr merged commit f006556 into ory:master Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants