Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hydra token user: add ability to not terminate on successful auth flow #2382

Closed
verzac opened this issue Mar 5, 2021 · 1 comment
Closed
Labels
feat New feature or request. good first issue A good issue to tackle when being a novice to the project. help wanted We are looking for help on this one.
Milestone

Comments

@verzac
Copy link
Contributor

verzac commented Mar 5, 2021

Either way, this is a nice-to-have, so it's not 100% necessary - just wanted to get the idea out there and looked at just in case a contributor comes along and wants to contribute. Happy to help when I have the time though!

Is your feature request related to a problem? Please describe.

When I'm testing the auth flow locally with the custom IdP I'm developing, I'd like for the token client to not close when auth flow is complete, so that I can keep on testing live changes to the auth flow iteratively.

Describe the solution you'd like

Make this line here optional: https://github.com/ory/hydra/blob/master/cmd/token_user.go#L238

We can probably do this through a very optional flag called --no-shutdown.

Now, I know it generates a nonce and a state when it starts up, and I'm not 100% aware if nonces/states can be reused when auth-ing with Hydra (it probably can't and shouldn't), so we might need hydra token to reset when GET /callback is called.

Describe alternatives you've considered

It's just a nice-to-have for lazy bums like me, so the alternative is running hydra token user again and again every time I want to test the auth flow.

@aeneasr
Copy link
Member

aeneasr commented Mar 5, 2021

Sounds good to me! Would you be up for a contribution? :) state and nonce should probably be regenerated when we redo the flow :)

@aeneasr aeneasr added good first issue A good issue to tackle when being a novice to the project. help wanted We are looking for help on this one. feat New feature or request. labels Mar 5, 2021
@aeneasr aeneasr added this to the unplanned milestone Mar 5, 2021
@aeneasr aeneasr closed this as completed in a17d10e Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request. good first issue A good issue to tackle when being a novice to the project. help wanted We are looking for help on this one.
Projects
None yet
Development

No branches or pull requests

2 participants