Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Clearer wording in SPA notice for HTML forms #2565

Merged
merged 1 commit into from
Jun 11, 2021
Merged

docs: Clearer wording in SPA notice for HTML forms #2565

merged 1 commit into from
Jun 11, 2021

Conversation

louis-lau
Copy link
Contributor

@louis-lau louis-lau commented Jun 10, 2021

Related issue

https://ory-community.slack.com/archives/C012RBW0F18/p1621977892051700

Proposed changes

As discussed in slack @vinckr, a little clearer wording for the notice about HTML forms in the hydra docs.

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further comments

I edited the notice in all doc versions, let me know if you want it done another way :)

@CLAassistant
Copy link

CLAassistant commented Jun 10, 2021

CLA assistant check
All committers have signed the CLA.

@vinckr
Copy link
Member

vinckr commented Jun 11, 2021

Thank you for the contribution 🎉 !

To make the format check pass, could you please run:
cd docs; npm i; npm run format
from the hydra main dir?

In the future we could consider using something like the APIWarning for Kratos here as well, it should make editing this easier, but I don't think it is necessary for this PR.

@louis-lau
Copy link
Contributor Author

Good one, I've amended my commit, it's formatted with prettier now :)

@aeneasr
Copy link
Member

aeneasr commented Jun 11, 2021

Thank you! :)

@aeneasr aeneasr merged commit 64a332a into ory:master Jun 11, 2021
@louis-lau louis-lau deleted the SPA-docs-improvement branch June 11, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants