Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed outdated information in doc configuration section #2723

Merged
merged 5 commits into from
Sep 8, 2021

Conversation

tnvmadhav
Copy link
Contributor

@tnvmadhav tnvmadhav commented Sep 7, 2021

Related issue(s)

Checklist

Further Comments

This fixes #2452

@CLAassistant
Copy link

CLAassistant commented Sep 7, 2021

CLA assistant check
All committers have signed the CLA.

@tnvmadhav tnvmadhav marked this pull request as ready for review September 7, 2021 13:28
@tnvmadhav tnvmadhav changed the title docs: removed outdated information in configuration section fix: removed outdated information in doc configuration section Sep 7, 2021
@tnvmadhav tnvmadhav marked this pull request as draft September 7, 2021 13:46
@tnvmadhav tnvmadhav marked this pull request as ready for review September 7, 2021 14:06
@aeneasr
Copy link
Member

aeneasr commented Sep 7, 2021

Thank you for these changes! Unfortunately almost all documents - except the Dockerfile - are autogenerated and need to fixed elsewhere. Here are some of those files:

Also keep in mind that the $HOME behavior was changed only recently. I don’t recall which version exactly but it is the one where we introduced Koanf / the new config handling!

@tnvmadhav
Copy link
Contributor Author

Thanks for the clarification 👍🏻

It seems that koanf was introduced with ory hydra v1.9.0 release
🔗 https://github.com/ory/hydra/releases/tag/v1.9.0

That would mean that we need to maintain two versions of docusaurus-templates:

  1. for ory hydra < v1.9.0 => with outdated info persisted
  2. for ory hydra >= v1.9.0 => with outdated info removed

@aeneasr
Copy link
Member

aeneasr commented Sep 8, 2021

Great, thank you! Would you also be open to make the change to

https://github.com/ory/docusaurus-template/blob/4f54031b6d278a92f89f4f6c6c968658a20bb547/scripts/config.js#L223

? :)

@aeneasr aeneasr merged commit 3f16045 into ory:master Sep 8, 2021
aeneasr added a commit to ory/docusaurus-template that referenced this pull request Sep 8, 2021
@aeneasr
Copy link
Member

aeneasr commented Sep 8, 2021

Ah, nvm, I quickly removed it myself :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants