feat: add method to detect public keys without prefixing #2758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # oauth2/handler_test.go # persistence/sql/persister_oauth2.go
Co-authored-by: hackerman <3372410+aeneasr@users.noreply.github.com>
Co-authored-by: hackerman <3372410+aeneasr@users.noreply.github.com>
|
Timo Doernenburg seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
aeneasr
commented
Sep 20, 2021
jwk/helper.go
Outdated
| @@ -49,13 +49,6 @@ func AsymmetricKeypair(ctx context.Context, r InternalRegistry, g KeyGenerator, | |||
| if err != nil { | |||
| return nil, nil, err | |||
| } | |||
| keys, err := r.KeyManager().GetKeySet(ctx, set) | |||
There was a problem hiding this comment.
I removed this because it served no purpose / did not make sense in this context and had no tests
jwk/jwt_strategy.go
Outdated
| @@ -113,7 +114,7 @@ func (j *RS256JWTStrategy) refresh(ctx context.Context) error { | |||
| return err | |||
| } | |||
|
|
|||
| public, err := FindPublicKey(keys) | |||
| public, err := FindKeyByPrefix(keys, "public") | |||
There was a problem hiding this comment.
I reverted this because we still rely on the private: pattern to be available for private keys.
Codecov Report
@@ Coverage Diff @@
## master #2758 +/- ##
==========================================
- Coverage 52.82% 50.50% -2.32%
==========================================
Files 235 235
Lines 14112 14721 +609
==========================================
- Hits 7454 7435 -19
- Misses 6028 6626 +598
- Partials 630 660 +30
Continue to review full report at Codecov.
|
aarmam
added a commit
to aarmam/hydra
that referenced
this pull request
Oct 19, 2021
6 tasks
aarmam
added a commit
to aarmam/hydra
that referenced
this pull request
Oct 19, 2021
aarmam
added a commit
to aarmam/hydra
that referenced
this pull request
Oct 20, 2021
aarmam
added a commit
to aarmam/hydra
that referenced
this pull request
Oct 26, 2021
aarmam
added a commit
to aarmam/hydra
that referenced
this pull request
Oct 27, 2021
aarmam
added a commit
to aarmam/hydra
that referenced
this pull request
Nov 2, 2021
aarmam
added a commit
to aarmam/hydra
that referenced
this pull request
Nov 8, 2021
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2459