-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace fatal error of jaeger initialization with print #2777
Conversation
Hi @aeneasr, I'm not sure why the CI test failed, could you tell me what I'm missing? I wasn't able to make sense of the logs either, the below step failed due to several connections being refused.
|
Ah yeah, that's just a flaky test :/ |
@aeneasr I've removed the retries and just logged the error as of now. Do let me know if I should revert to the 3 attempts + sleep approach. PS: Could you please add the |
Codecov Report
@@ Coverage Diff @@
## master #2777 +/- ##
==========================================
- Coverage 50.42% 50.42% -0.01%
==========================================
Files 235 235
Lines 14773 14775 +2
==========================================
+ Hits 7450 7451 +1
Misses 6664 6664
- Partials 659 660 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you for your contribution! This looks pretty good and I have some ideas how to improve it further :)
@aeneasr is there anything else I can add to this PR? |
Just waiting for CI to pass :) It's flaky atm but I am restarting the job now |
Hey @aeneasr, is there anything I have to change to pass the code coverage CI? |
thank you :) |
Replace
Fatalf()
withPrintln()
to log when unable to initialize a tracer. This avoid unnecessary exits.Additionally, total 3 attempts are made to init the tracer.Fixes #2642
CC: @aeneasr
Checklist
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.