Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds EdDSA support #2782

Merged
merged 2 commits into from
Oct 6, 2021
Merged

Conversation

NickUfer
Copy link
Contributor

@NickUfer NickUfer commented Oct 5, 2021

This PR adds support for the EdDSA algorithm and ed25519 curve keys.

Related issue(s)

Checklist

Further Comments

@NickUfer NickUfer requested a review from aeneasr as a code owner October 5, 2021 22:17
@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #2782 (025a127) into master (8901b09) will increase coverage by 0.02%.
The diff coverage is 68.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2782      +/-   ##
==========================================
+ Coverage   50.42%   50.45%   +0.02%     
==========================================
  Files         235      236       +1     
  Lines       14773    14800      +27     
==========================================
+ Hits         7450     7468      +18     
- Misses       6664     6671       +7     
- Partials      659      661       +2     
Impacted Files Coverage Δ
jwk/helper.go 64.83% <16.66%> (-3.77%) ⬇️
jwk/generator_eddsa.go 80.00% <80.00%> (ø)
cmd/keys_create.go 100.00% <100.00%> (ø)
driver/registry_base.go 89.32% <100.00%> (+0.04%) ⬆️
oauth2/hook.go 64.51% <100.00%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3710468...025a127. Read the comment docs.

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@aeneasr aeneasr merged commit 2ea49da into ory:master Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants