Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump ory/x to v0.0.330 #2912

Closed
wants to merge 5 commits into from
Closed

chore: bump ory/x to v0.0.330 #2912

wants to merge 5 commits into from

Conversation

matoous
Copy link
Contributor

@matoous matoous commented Jan 3, 2022

Tiny PR that bumps ory/x package to latest. New version includes support for open telemetry tracing (among other things).

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

@matoous matoous requested a review from aeneasr as a code owner January 3, 2022 11:21
New version includes support for open telemetry tracing.

Fixes: #2597
@matoous matoous changed the title deps: bump ory/x to v0.0.330 chore: bump ory/x to v0.0.330 Jan 3, 2022
@aeneasr
Copy link
Member

aeneasr commented Jan 4, 2022

Thank you! I think there is a koanf replacement missing which exists in ory/x's go.mod file. Could you please take a look?

aeneasr added a commit that referenced this pull request Jan 5, 2022
This fix addresses an issue where configuration values in arrays could not be loaded from environment variables, which is now possible. For more information on how Ory Hydra parses configuration, [head over to the documentation](https://www.ory.sh/docs/ecosystem/configuring/)!

Additionally, this PR resolves a build issue on FreeBSD - making it now possible to compile Ory Hydra with the FreeBSD target.

Lastly, this change adds OpenTelemetry support!

Closes #2597
Closes #2912
@matoous
Copy link
Contributor Author

matoous commented Jan 6, 2022

@aeneasr I don't see any replacement for koanf in ory/x, there's only github.com/knadh/koanf v1.3.0 in go.mod. I am sorry, I totally oblivious to what the issue is/why is it failing.

@aeneasr aeneasr closed this in 5158faa Jan 6, 2022
@aeneasr
Copy link
Member

aeneasr commented Jan 6, 2022

I updated koanf as my PR was merged, and merged your changes into the linked commit :) Thank you for the contrib! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants