refactor: refactor migration tests to use fixtures #2936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grantzvolsky
added a commit
to grantzvolsky/hydra
that referenced
this pull request
Feb 7, 2022
grantzvolsky
added a commit
to grantzvolsky/hydra
that referenced
this pull request
Mar 8, 2022
grantzvolsky
added a commit
that referenced
this pull request
May 19, 2022
aeneasr
pushed a commit
that referenced
this pull request
Jun 27, 2022
grantzvolsky
added a commit
that referenced
this pull request
Aug 1, 2022
aeneasr
pushed a commit
that referenced
this pull request
Aug 1, 2022
aeneasr
pushed a commit
that referenced
this pull request
Aug 18, 2022
aeneasr
pushed a commit
that referenced
this pull request
Sep 5, 2022
aeneasr
pushed a commit
that referenced
this pull request
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2901
In order to ensure that the fixtures are correct, I made sure that the old tests passed while generating the fixtures, before removing the old tests.
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments