Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parallel generation of JSON web key set #3561

Merged
merged 2 commits into from Jul 5, 2023
Merged

Conversation

alnr
Copy link
Contributor

@alnr alnr commented Jun 30, 2023

First-time generation of RSA keys can take upwards of 5 sec per key. This is a quick improvement to the first-call performance of this endpoint. Should help with tests timing out etc.

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #3561 (73df82d) into master (efd9ca7) will increase coverage by 0.00%.
The diff coverage is 69.56%.

❗ Current head 73df82d differs from pull request most recent head 1c2b55e. Consider uploading reports for the commit 1c2b55e to get more accurate results

@@           Coverage Diff           @@
##           master    #3561   +/-   ##
=======================================
  Coverage   76.61%   76.62%           
=======================================
  Files         129      129           
  Lines        9554     9562    +8     
=======================================
+ Hits         7320     7327    +7     
  Misses       1739     1739           
- Partials      495      496    +1     
Impacted Files Coverage Δ
jwk/handler.go 69.38% <69.56%> (+1.60%) ⬆️

@alnr alnr self-assigned this Jun 30, 2023
@alnr alnr marked this pull request as ready for review June 30, 2023 16:36
@alnr alnr requested a review from aeneasr as a code owner June 30, 2023 16:36
aeneasr
aeneasr previously approved these changes Jul 5, 2023
@aeneasr aeneasr merged commit 5bd9002 into master Jul 5, 2023
29 checks passed
@aeneasr aeneasr deleted the parallel-keygen branch July 5, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants