Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docker build #3609

Merged
merged 1 commit into from Aug 16, 2023
Merged

fix: docker build #3609

merged 1 commit into from Aug 16, 2023

Conversation

hperl
Copy link
Contributor

@hperl hperl commented Aug 16, 2023

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hperl hperl requested a review from aeneasr as a code owner August 16, 2023 18:47
@hperl hperl self-assigned this Aug 16, 2023
@hperl
Copy link
Contributor Author

hperl commented Aug 16, 2023

/cc @Demonsthere the builder image glibc must not be newer than the runner image glibc.

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #3609 (f4391e3) into master (1f1121c) will not change coverage.
Report is 2 commits behind head on master.
The diff coverage is n/a.

❗ Current head f4391e3 differs from pull request most recent head e9e12e1. Consider uploading reports for the commit e9e12e1 to get more accurate results

@@           Coverage Diff           @@
##           master    #3609   +/-   ##
=======================================
  Coverage   76.22%   76.22%           
=======================================
  Files         132      132           
  Lines       10009    10009           
=======================================
  Hits         7629     7629           
  Misses       1860     1860           
  Partials      520      520           

@aeneasr aeneasr merged commit 01ff9da into master Aug 16, 2023
30 checks passed
@aeneasr aeneasr deleted the hperl/fix-docker branch August 16, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants