Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/server: Die when system secret is in wrong format #817

Closed
aeneasr opened this issue Mar 19, 2018 · 5 comments
Closed

cmd/server: Die when system secret is in wrong format #817

aeneasr opened this issue Mar 19, 2018 · 5 comments
Assignees
Labels
feat New feature or request.

Comments

@aeneasr
Copy link
Member

aeneasr commented Mar 19, 2018

Follow up to #816

@aeneasr aeneasr added the feat New feature or request. label Mar 19, 2018
@aeneasr aeneasr self-assigned this Mar 19, 2018
@nicerobot
Copy link

nicerobot commented Mar 19, 2018

Maybe this is also partly a documentation enhancement:

$ export SYSTEM_SECRET=this_needs_to_be_the_same_always_and_also_very_$3cuR3-._

is fine to explain the variable but we could also recommend a fast way to obtain a relatively secure secret, e.g.:

$ export SYSTEM_SECRET=$(export LC_CTYPE=C; cat /dev/urandom | tr -dc 'a-zA-Z0-9' | fold -w 32 | head -n 1)

The key here being that I was aware that I would need to retain this secret but I didn't catch that the first time I tried, the secret I used was ignored and a random one was generated. So when I tried restarting with the same insecure secret, it caused the failure which was unexpected.

@aeneasr
Copy link
Member Author

aeneasr commented Mar 20, 2018

Yeah, that's an awesome suggestion @nicerobot ! Got some unix swag! You don't know - by any chance - the equivalent for windows?

@nicerobot
Copy link

@arekkas I don't but i can look into it.

@nicerobot
Copy link

@arekkas I've had it tested in the Windows 10 Linux Subsystem and that does work. Now, figuring out a solution for Windows classic shell is another story.

@aeneasr
Copy link
Member Author

aeneasr commented Jul 7, 2018

Tracked as ory/docs#27

@aeneasr aeneasr closed this as completed Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request.
Projects
None yet
Development

No branches or pull requests

2 participants