Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of helm test framework #127

Closed
aeneasr opened this issue Mar 31, 2020 · 2 comments
Closed

Make use of helm test framework #127

aeneasr opened this issue Mar 31, 2020 · 2 comments
Labels
feat New feature or request. stale Feedback from one or more authors is required to proceed.
Milestone

Comments

@aeneasr
Copy link
Member

aeneasr commented Mar 31, 2020

Is your feature request related to a problem? Please describe.

Currently, we execute only very basic tests that use health checks to see if a service is up or not after installation.

We had several bugs in the helm charts that could have been caught if we used more advanced tests.

Describe the solution you'd like

Introduce better tests, for example:

  • Was the config map created? Does it have the right content?
  • Was the secret created and mounted? Does it have the right content?
  • Is the CRD Controller running properly and does it update the service when a CRD changes?
  • ...

Describe alternatives you've considered

Open to other ideas!

Additional context

Help would be appreciated!

@aeneasr aeneasr added feat New feature or request. up for grab labels Mar 31, 2020
@github-actions
Copy link

I am marking this issue as stale as it has not received any engagement from the community or maintainers in over half a year. That does not imply that the issue has no merit! If you feel strongly about this issue

  • open a PR referencing and resolving the issue;
  • leave a comment on it and discuss ideas how you could contribute towards resolving it;
  • open a new issue with updated details and a plan on resolving the issue.

We are cleaning up issues every now and then, primarily to keep the 4000+ issues in our backlog in check and to prevent maintainer burnout. Burnout in open source maintainership is a widespread and serious issue. It can lead to severe personal and health issues as well as enabling catastrophic attack vectors.

Thank you for your understanding and to anyone who participated in the issue! 🙏✌️

If you feel strongly about this issues and have ideas on resolving it, please comment. Otherwise it will be closed in 30 days!

@github-actions github-actions bot added the stale Feedback from one or more authors is required to proceed. label Sep 21, 2021
@aeneasr aeneasr removed the stale Feedback from one or more authors is required to proceed. label Sep 21, 2021
@aeneasr aeneasr added this to the backlog milestone Sep 21, 2021
@github-actions
Copy link

Hello contributors!

I am marking this issue as stale as it has not received any engagement from the community or maintainers a year. That does not imply that the issue has no merit! If you feel strongly about this issue

  • open a PR referencing and resolving the issue;
  • leave a comment on it and discuss ideas how you could contribute towards resolving it;
  • leave a comment and describe in detail why this issue is critical for your use case;
  • open a new issue with updated details and a plan on resolving the issue.

Throughout its lifetime, Ory has received over 10.000 issues and PRs. To sustain that growth, we need to prioritize and focus on issues that are important to the community. A good indication of importance, and thus priority, is activity on a topic.

Unfortunately, burnout has become a topic of concern amongst open-source projects.

It can lead to severe personal and health issues as well as opening catastrophic attack vectors.

The motivation for this automation is to help prioritize issues in the backlog and not ignore, reject, or belittle anyone.

If this issue was marked as stale erroneous you can exempt it by adding the backlog label, assigning someone, or setting a milestone for it.

Thank you for your understanding and to anyone who participated in the conversation! And as written above, please do participate in the conversation if this topic is important to you!

Thank you 🙏✌️

@github-actions github-actions bot added the stale Feedback from one or more authors is required to proceed. label Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request. stale Feedback from one or more authors is required to proceed.
Projects
None yet
Development

No branches or pull requests

1 participant