Private docker registry is causing chart installation to fail

[bzlom]

Preflight checklist

• I could not find a solution in the existing issues, docs, nor discussions.
• I agree to follow this project's Code of Conduct.
• I have read and am following this repository's Contribution Guidelines.
• This issue affects my Ory Cloud project.
• I have joined the Ory Community Slack.
• I am signed up to the Ory Security Patch Newsletter.

Describe the bug

When trying to use ory Kratos helm chart with a private docker registry the deployment of kubernetes resources can fail for 2 reasons:

1. if you enable automigration
2. when the chart is deploying the courier

Reproducing the bug

Steps to reproduce the behaviour, we're using argo-cd to deploy our helm charts:

1. Provide a private registry: repository: some-private-registry/oryd/kratos
2. Provide the imagePullSecrets value, making sure you've created the kubernetes secret (for accessing this private docker registry) in the correct namespace where you'll be deploying ory-kratos
3. enable automigration: autoMigrate: true

Relevant log output

Normal   Pulling    29m (x4 over 30m)    kubelet            Pulling image "some-private-registry/oryd/kratos:v0.6.3-alpha.1"
  Warning  Failed     29m (x4 over 30m)    kubelet            Failed to pull image "some-private-registry/oryd/kratos:v0.6.3-alpha.1": rpc error: code = Unknown desc = Error response from daemon: Head "https://some-private-registry/v2/oryd/kratos/manifests/v0.6.3-alpha.1": no basic auth credentials
  Warning  Failed     29m (x4 over 30m)    kubelet            Error: ErrImagePull
  Warning  Failed     29m (x6 over 30m)    kubelet            Error: ImagePullBackOff

Relevant configuration

apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
  name: ory-kratos-test
  namespace: argocd
spec:
  destination:
    name: ''
    namespace: kratos
    server: 'https://kubernetes.default.svc'
  source:
    path: ''
    repoURL: 'https://k8s.ory.sh/helm/charts'
    targetRevision: 0.20.2
    chart: kratos
    helm:
      values: |-
        image:
          repository: some-private-registry/oryd/kratos
          tag: v0.6.3-alpha.1
          pullPolicy: IfNotPresent
        imagePullSecrets:
        - name: infra-v1-nexus-pull-secret
...............
...............
        kratos:
          autoMigrate: false

Version

happens in both 0.15.1 and 0.20.2

On which operating system are you observing this issue?

Linux

In which environment are you deploying?

Kubernetes with Helm

Additional Context

I've had a look through the helm chart code for kratos and it looks the problem stems from the fact that in certain helm templates there isn't any reference to imagePullSecrets: defined in deployment.yaml. For example in our specific case: job-migration.yaml and statefulset-mail.yaml maybe there are more

[Demonsthere]

Hello there!
You are right, when reworking the charts we somehow forgot the imagePullSecrets. Already created a PR to fix that :)