Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose function to generate OPL #1057

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Conversation

hperl
Copy link
Collaborator

@hperl hperl commented Oct 7, 2022

With the OPL landed, we want to expose some functionality to migrate from the legacy namespaces to the OPL-defined namespaces.

This PR exposes a GenerateOPLConfig function to do this. Exposing this in the Keto CLI is future work.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hperl hperl requested a review from zepatrik as a code owner October 7, 2022 11:16
@hperl hperl force-pushed the feat/migrate-namespace-config branch from 3e3552f to 0be3e13 Compare October 7, 2022 11:19
Co-authored-by: Patrik <zepatrik@users.noreply.github.com>
@hperl hperl force-pushed the feat/migrate-namespace-config branch from 0be3e13 to bd132b2 Compare October 7, 2022 11:22
@hperl hperl self-assigned this Oct 7, 2022
Copy link
Member

@zepatrik zepatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like the idea 😜

@zepatrik zepatrik merged commit b80a230 into master Oct 10, 2022
@zepatrik zepatrik deleted the feat/migrate-namespace-config branch October 10, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants