Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: relax OPL parsing #1059

Merged
merged 1 commit into from
Oct 10, 2022
Merged

fix: relax OPL parsing #1059

merged 1 commit into from
Oct 10, 2022

Conversation

hperl
Copy link
Collaborator

@hperl hperl commented Oct 7, 2022

  • Allow semicolons in more places
  • Allow commas in more places

Fixes #1046

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

* Allow semicolons in more places
* Allow commas in more places
@hperl hperl requested a review from zepatrik as a code owner October 7, 2022 13:29
Copy link
Member

@zepatrik zepatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, really like how easy those kinds of changes are with the lexer and parser design 😍

@zepatrik zepatrik merged commit a15c5ad into master Oct 10, 2022
@zepatrik zepatrik deleted the fix-opl-parsing branch October 10, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

keto OPL parsing error
2 participants