Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor subjects to always have namespaces #1092

Closed
3 of 6 tasks
zepatrik opened this issue Oct 27, 2022 · 2 comments
Closed
3 of 6 tasks

Refactor subjects to always have namespaces #1092

zepatrik opened this issue Oct 27, 2022 · 2 comments
Labels
feat New feature or request. stale Feedback from one or more authors is required to proceed.
Milestone

Comments

@zepatrik
Copy link
Member

Preflight checklist

Describe your problem

We currently distinguish subject IDs and subject sets. This is confusing on the API side for consumers, and annoying in the code.

Describe your ideal solution

Subjects and objects should actually be treated the same way, requiring a namespace and ID. For subjects there should just be the optional relation available, making the tuple a "subject set tuple".

Workarounds or alternatives

Keep as is or drop subject sets completely. With OPL the use-cases for subject sets are quite reduced, so it might be a valid option.

Version

v0

Additional Context

No response

@zepatrik zepatrik added the feat New feature or request. label Oct 27, 2022
@zepatrik zepatrik added this to the v1 milestone Oct 27, 2022
@hperl
Copy link
Collaborator

hperl commented Jan 19, 2023

@zepatrik, WDYT, should we also put this behaviour behind the experimental_strict_mode flag?

Copy link

Hello contributors!

I am marking this issue as stale as it has not received any engagement from the community or maintainers for a year. That does not imply that the issue has no merit! If you feel strongly about this issue

  • open a PR referencing and resolving the issue;
  • leave a comment on it and discuss ideas on how you could contribute towards resolving it;
  • leave a comment and describe in detail why this issue is critical for your use case;
  • open a new issue with updated details and a plan for resolving the issue.

Throughout its lifetime, Ory has received over 10.000 issues and PRs. To sustain that growth, we need to prioritize and focus on issues that are important to the community. A good indication of importance, and thus priority, is activity on a topic.

Unfortunately, burnout has become a topic of concern amongst open-source projects.

It can lead to severe personal and health issues as well as opening catastrophic attack vectors.

The motivation for this automation is to help prioritize issues in the backlog and not ignore, reject, or belittle anyone.

If this issue was marked as stale erroneously you can exempt it by adding the backlog label, assigning someone, or setting a milestone for it.

Thank you for your understanding and to anyone who participated in the conversation! And as written above, please do participate in the conversation if this topic is important to you!

Thank you 🙏✌️

@github-actions github-actions bot added the stale Feedback from one or more authors is required to proceed. label Jan 20, 2024
@zepatrik zepatrik reopened this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request. stale Feedback from one or more authors is required to proceed.
Projects
None yet
Development

No branches or pull requests

2 participants