Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow comments in more places in the OPL #1117

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Conversation

hperl
Copy link
Collaborator

@hperl hperl commented Nov 8, 2022

Related issue(s)

Fixes #1116

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hperl hperl requested a review from zepatrik as a code owner November 8, 2022 14:25
@hperl hperl self-assigned this Nov 8, 2022
@hperl hperl added the bug Something is not working. label Nov 8, 2022
Copy link
Member

@zepatrik zepatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@hperl hperl merged commit 5f89fcf into master Nov 8, 2022
@hperl hperl deleted the hperl/fix-opl-parser branch November 8, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OPL parser does not recognize line comments after OR operator
2 participants