Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not return nil on unknown subject set on expand #1139

Merged
merged 2 commits into from
Nov 18, 2022
Merged

fix: do not return nil on unknown subject set on expand #1139

merged 2 commits into from
Nov 18, 2022

Conversation

zepatrik
Copy link
Member

Unknown subject sets resulted in nil being returned, which in turn caused panics in the handler.

@zepatrik zepatrik requested a review from hperl as a code owner November 18, 2022 14:28
zepatrik
zepatrik commented Nov 18, 2022
View reviewed changes
internal/expand/engine.go Outdated Show resolved Hide resolved
@zepatrik zepatrik merged commit 1f3c568 into master Nov 18, 2022
@zepatrik zepatrik deleted the fix/nil-on-unknown-subject_set branch November 18, 2022 18:00
@zepatrik zepatrik mentioned this pull request Jan 19, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hperl hperl Awaiting requested review from hperl hperl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@zepatrik