Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update up.sh to allow usage without tls (issue #1133) #1158

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

gousse
Copy link
Contributor

@gousse gousse commented Dec 2, 2022

fix errors due to not using TLS on the example. Need to add --insecure-disable-transport-security option to command lines

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

fix errors due to not using TLS on the example. Need to add --insecure-disable-transport-security option to command lines
@CLAassistant
Copy link

CLAassistant commented Dec 2, 2022

CLA assistant check
All committers have signed the CLA.

@gousse gousse mentioned this pull request Dec 2, 2022
6 tasks
@gousse gousse changed the title Update up.sh fix: Update up.sh to allow usage without tls Dec 2, 2022
@gousse gousse changed the title fix: Update up.sh to allow usage without tls fix: update up.sh to allow usage without tls (issue #1133) Dec 2, 2022
Copy link
Member

@zepatrik zepatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

contrib/cat-videos-example/up.sh Show resolved Hide resolved
@zepatrik zepatrik merged commit 30a74c6 into ory:master Dec 2, 2022
@gousse gousse deleted the patch-2 branch December 2, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants