fix: readonly UUID mapping inserts #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Endpoints that do not mutate the database (such as list or check) now use a read-only version of the UUID mapper that does not write the mapping to the database (as all relevant mapping information is already mapped).
hperl
changed the title
zepatrik
reviewed
Jan 16, 2023
zepatrik
reviewed
Jan 17, 2023
|
|
||
| reUnmapped, err := roMapper.ToQuery(ctx, mapped) | ||
| require.NoError(t, err) | ||
| assert.Empty(t, reUnmapped.Object) |
There was a problem hiding this comment.
Hmm, maybe this case should instead return an error, as the RO mapper is unable to do the mapping? Just to not have bugs later on.
hperl
force-pushed
the
hperl/fix-readmode-uuid-mapping-inserts
branch
from
30f0e47
to
ef4ed58
Compare
zepatrik
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a read-only version of the UUID mapper that performs the mappings but does not write them to the database. This mapper suffices for all endpoints that do not add new tuples to the database, and is obviously much faster that the read-write version of the mapper.
Tests were added to show that the read-only mapper behaves the same as the read-write version, if all information is already mapped.
Related issue(s)
Fixes #1076
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments