fix: subject expansion is terminated unexpectedly #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zepatrik
approved these changes
Feb 24, 2023
Comment on lines
+140
to
+145
| sub := &relationtuple.SubjectSet{ | ||
| Namespace: result.To.Namespace, | ||
| Object: result.To.Object, | ||
| Relation: result.To.Relation, | ||
| } | ||
| innerCtx, visited = graph.CheckAndAddVisited(innerCtx, sub) |
There was a problem hiding this comment.
Good catch, at this point result.To.Subject is the same for all results:
keto/internal/persistence/sql/traverser.go
Line 108 in db59a33
zepatrik
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Hello @stonelgh |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the issue that subject expansion will fail if the depth exceeds 2.
Related issue(s)
closes #1255
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments